Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Rafał Miłecki" <zajec5@xxxxxxxxx>
> An: "Michael Walle" <michael@xxxxxxxx>, "linux-mtd" <linux-mtd@xxxxxxxxxxxxxxxxxxx>, "linux-kernel"
> <linux-kernel@xxxxxxxxxxxxxxx>
> CC: "Miquel Raynal" <miquel.raynal@xxxxxxxxxxx>, "richard" <richard@xxxxxx>, "Vignesh Raghavendra" <vigneshr@xxxxxx>,
> "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>
> Gesendet: Montag, 22. März 2021 17:39:41
> Betreff: Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

> On 03.03.2021 16:57, Michael Walle wrote:
>> MEMLOCK, MEMUNLOCK and OTPLOCK modify protection bits. Thus require
>> write permission. Depending on the hardware MEMLOCK might even be
>> write-once, e.g. for SPI-NOR flashes with their WP# tied to GND. OTPLOCK
>> is always write-once.
>> 
>> MEMSETBADBLOCK modifies the bad block table.
>> 
>> Fixes: f7e6b19bc764 ("mtd: properly check all write ioctls for permissions")
>> Signed-off-by: Michael Walle <michael@xxxxxxxx>
> 
> Should be fine for OpenWrt tools to my best knowledge (and quick testing).
> 
> Acked-by: Rafał Miłecki <rafal@xxxxxxxxxx>

Nice!

Acked-by: Richard Weinberger <richard@xxxxxx>

Thanks,
//richard