Re: [PATCH] bpf: avoid old-style declaration warnings

From: KP Singh
Date: Mon Mar 22 2021 - 20:13:49 EST


On Mon, Mar 22, 2021 at 10:52 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> gcc -Wextra wants type modifiers in the normal order:
>
> kernel/bpf/bpf_lsm.c:70:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
> 70 | const static struct bpf_func_proto bpf_bprm_opts_set_proto = {
> | ^~~~~
> kernel/bpf/bpf_lsm.c:91:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
> 91 | const static struct bpf_func_proto bpf_ima_inode_hash_proto = {
> | ^~~~~
>
> Fixes: 3f6719c7b62f ("bpf: Add bpf_bprm_opts_set helper")
> Fixes: 27672f0d280a ("bpf: Add a BPF helper for getting the IMA hash of an inode")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks for fixing!

Acked-by: KP Singh <kpsingh@xxxxxxxxxx>