Re: [PATCH] rcu: Fix various typos in comments

From: Paul E. McKenney
Date: Tue Mar 23 2021 - 01:33:24 EST


On Mon, Mar 22, 2021 at 07:55:05PM -0700, Randy Dunlap wrote:
> On 3/22/21 4:02 PM, Ingo Molnar wrote:
> >
> > Hi Paul,
> >
> > Was working on automation to make it a bit more straightforward to fix
> > typos within comments (which we tend to reintroduce during
> > development), and here are the ones it found in the RCU code.
> >
> > Thanks,
> >
> > Ingo
> >
> > =========>
> > From: Ingo Molnar <mingo@xxxxxxxxxx>
> > Date: Mon, 22 Mar 2021 23:57:26 +0100
> > Subject: [PATCH] rcu: Fix various typos in comments
> >
> > Fix ~12 single-word typos in RCU code comments.
> >
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Paul E. McKenney <paulmck@xxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > ---
> > kernel/rcu/srcutree.c | 4 ++--
> > kernel/rcu/sync.c | 2 +-
> > kernel/rcu/tasks.h | 8 ++++----
> > kernel/rcu/tree.c | 4 ++--
> > kernel/rcu/tree.h | 2 +-
> > kernel/rcu/tree_plugin.h | 2 +-
> > tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/locks.h | 2 +-
> > 7 files changed, 12 insertions(+), 12 deletions(-)
>
> > diff --git a/kernel/rcu/sync.c b/kernel/rcu/sync.c
> > index d4558ab7a07d..3eeb871cf0de 100644
> > --- a/kernel/rcu/sync.c
> > +++ b/kernel/rcu/sync.c
> > @@ -94,7 +94,7 @@ static void rcu_sync_func(struct rcu_head *rhp)
> > rcu_sync_call(rsp);
> > } else {
> > /*
> > - * We're at least a GP after the last rcu_sync_exit(); eveybody
> > + * We're at least a GP after the last rcu_sync_exit(); everybody
> > * will now have observed the write side critical section.
> > * Let 'em rip!.
>
> Drop the '.'.
>
> > */
> Otherwise LGTM. Thanks.
>
> Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Applied, dropping the "." and adding the Reviewed-by.

Thank you both!

Thanx, Paul