Re: [PATCH v4 0/4] man2: udpate mm/userfaultfd manpages to latest

From: Mike Rapoport
Date: Tue Mar 23 2021 - 04:32:38 EST


On Mon, Mar 22, 2021 at 06:08:44PM -0400, Peter Xu wrote:
> v4:
> - Fixed a few "subordinate clauses" (SC) cases [Alex]
> - Reword in ioctl_userfaultfd.2 to use bold font for the two modes referenced,
> so as to be clear on what is "both" referring to [Alex]
>
> v3:
> - Don't use "Currently", instead add "(since x.y)" mark where proper [Alex]
> - Always use semantic newlines across the whole patchset [Alex]
> - Use quote when possible, rather than escapes [Alex]
> - Fix one missing replacement of ".BR" -> ".B" [Alex]
> - Some other trivial rephrases here and there when fixing up above
>
> v2 changes:
> - Fix wordings as suggested [MikeR]
> - convert ".BR" to ".B" where proper for the patchset [Alex]
> - rearrange a few lines in the last two patches where they got messed up
> - document more things, e.g. UFFDIO_COPY_MODE_WP; and also on how to resolve a
> wr-protect page fault.
>
> There're two features missing in current manpage, namely:
>
> (1) Userfaultfd Thread-ID feature
> (2) Userfaultfd write protect mode
>
> There's also a 3rd one which was just contributed from Axel - Axel, I think it
> would be great if you can add that part too, probably after the whole
> hugetlbfs/shmem minor mode reaches the linux master branch.
>
> Please review, thanks.
>
> Peter Xu (4):
> userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs
> userfaultfd.2: Add write-protect mode
> ioctl_userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs
> ioctl_userfaultfd.2: Add write-protect mode docs
>
> man2/ioctl_userfaultfd.2 | 89 ++++++++++++++++++++++++++++-
> man2/userfaultfd.2 | 117 ++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 201 insertions(+), 5 deletions(-)

Acked-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>

> --
> 2.26.2
>
>

--
Sincerely yours,
Mike.