Re: [PATCH] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes

[Sameer Pujar]

On 3/24/2021 1:30 AM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> The nvidia,tegra210-ahub binding is missing schema for child nodes. This
> results in warnings if 'additionalProperties: false' is set (or when the
> tools implement 'unevaluatedProperties' support). Add the child nodes
> and reference their schema if one exists.
>
> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Jonathan Hunter <jonathanh@xxxxxxxxxx>
> Cc: Sameer Pujar <spujar@xxxxxxxxxx>
> Cc: alsa-devel@xxxxxxxxxxxxxxxx
> Cc: linux-tegra@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> This patch ideally should be applied before this series[1].
>
> [1] https://lore.kernel.org/r/20210323163634.877511-1-robh@xxxxxxxxxx/
>
>   .../bindings/sound/nvidia,tegra210-ahub.yaml         | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> index e568d6c7dddd..d7a5eb77ed4f 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> @@ -69,6 +69,18 @@ properties:
>           $ref: audio-graph-port.yaml#
>           unevaluatedProperties: false
>
> +patternProperties:
> +  '^i2s@[0-9a-f]+$':
> +    type: object
> +
> +  '^dmic@[0-9a-f]+$':
> +    type: object
> +    $ref: nvidia,tegra210-dmic.yaml#
> +
> +  '^admaif@[0-9a-f]+$':
> +    type: object
> +    $ref: nvidia,tegra210-admaif.yaml#
> +

There is "dspk@xxx" child node as well for ahub, though schema example 
does not show this. I am seeing error because of this during 
"dtbs_check". Wondering if we can add following with this patch?

+  '^dspk@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra186-dspk.yaml#


>   required:
>     - compatible
>     - reg
> --
> 2.27.0