Re: [PATCH] fs/fuse/virtio_fs: Fix a potential memory allocation failure

From: Connor Kuehl
Date: Wed Mar 24 2021 - 09:59:22 EST


On 3/24/21 7:38 AM, zhouchuangao wrote:
Allocate memory for struct fuse_conn may fail, we should not jump to
out_err to kfree(fc).

Why not? If fc's allocation fails then it is NULL and calling kfree() on a NULL pointer is a noop[1].

Connor

[1] https://www.kernel.org/doc/html/latest/core-api/mm-api.html?highlight=kfree#c.kfree