Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn6750

[Rob Herring]

On Thu, Mar 11, 2021 at 10:28:24PM +0530, Venkata Lakshmi Narayana Gubba wrote:
> This patch enables regulators and gpios for the Qualcomm Bluetooth wcn6750
> controller.
> 
> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@xxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/net/qualcomm-bluetooth.txt | 43 ++++++++++++++++++++++
>  1 file changed, 43 insertions(+)

This is a large change. Please convert to DT schema first.

> 
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> index 709ca6d..e70fcb7 100644
> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> @@ -15,6 +15,7 @@ Required properties:
>     * "qcom,wcn3991-bt"
>     * "qcom,wcn3998-bt"
>     * "qcom,qca6390-bt"
> +   * "qcom,wcn6750-bt"
>  
>  Optional properties for compatible string qcom,qca6174-bt:
>  
> @@ -39,6 +40,26 @@ Optional properties for compatible string qcom,wcn399x-bt:
>   - firmware-name: specify the name of nvm firmware to load
>   - clocks: clock provided to the controller
>  
> +Required properties for compatible string qcom,wcn6750-bt:
> +
> + - enable-gpios: gpio specifier used to enable chip
> + - swctrl-gpios: gpio specifier is output from SoC,used to find status
> +		 of clock supply to SoC.
> + - vddio-supply: VDD_IO supply regulator handle.
> + - vddaon-supply: VDD_AON supply regulator handle.
> + - vddbtcxmx-suppl: VDD_BT_CXMX supply regualtor handle.
> + - vddrfacmn-supply: VDD_RFA_CMN supply regulator handle.
> + - vddrfa0p8-supply: VDD_RFA_0P8 suppply regulator handle.
> + - vddrfa1p7-supply: VDD_RFA_1P7 supply regulator handle.
> + - vddrfa1p2-supply: VDD_RFA_1P2 supply regulator handle.
> + - vddrfa2p2-supply: VDD_RFA_2P2 supply regulator handle.
> + - vddasd-supply: VDD_ASD supply regulator handle.
> +
> +Optional properties for compatible string qcom,wcn6750-bt:
> +
> + - max-speed: see Documentation/devicetree/bindings/serial/serial.yaml
> + - firmware-name: specify the name of nvm firmware to load
> +
>  Examples:
>  
>  serial@7570000 {
> @@ -67,3 +88,25 @@ serial@898000 {
>  		clocks = <&rpmhcc RPMH_RF_CLK2>;
>  	};
>  };
> +
> +serial@99c000 {
> +	bluetooth {
> +		compatible = "qcom,wcn6750-bt";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&bt_en_default>;
> +		enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
> +		swctrl-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>;
> +		vddio-supply = <&vreg_l19b_1p8>;
> +		vddaon-supply = <&vreg_s7b_0p9>;
> +		vddbtcxmx-supply = <&vreg_s7b_0p9>;
> +		vddrfacmn-supply = <&vreg_s7b_0p9>;
> +		vddrfa0p8-supply = <&vreg_s7b_0p9>;
> +		vddrfa1p7-supply = <&vreg_s1b_1p8>;
> +		vddrfa1p2-supply = <&vreg_s8b_1p2>;
> +		vddrfa2p2-supply = <&vreg_s1c_2p2>;
> +		vddasd-supply = <&vreg_l11c_2p8>;
> +		max-speed = <3200000>;
> +		firmware-name = "msnv11.bin";
> +	};
> +};
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
> of Code Aurora Forum, hosted by The Linux Foundation
>