Re: [PATCH v2] kbuild: enforce -Werror=unused-result

From: Masahiro Yamada
Date: Thu Mar 25 2021 - 12:57:38 EST


On Thu, Mar 25, 2021 at 8:16 PM Olaf Hering <olaf@xxxxxxxxx> wrote:
>
> Am Fri, 19 Mar 2021 15:32:31 +0100
> schrieb Olaf Hering <olaf@xxxxxxxxx>:
>
> > It is a hard error if a return value is ignored.
>
> The automated builds found only a single error, in load_em86().


What about drivers/net/ethernet/lantiq_etop.c ?




> Let me know if there are other reasons why the patch was rejected.
>
> Olaf


I got a lot of complaints in the last trial.

It is easy to send a patch like this, but difficult to
make sure that I will not break any CI tests.

Over time, I started to believe keeping this as a warning
is OK.

The same problem happens when you add a new __must_check
annotation. You end up with fixing all the call-sites in advance.


--
Best Regards
Masahiro Yamada