Re: [PATCH] media: sq905.c: fix uninitialized variable

From: Dmitry Vyukov
Date: Fri Mar 26 2021 - 03:15:37 EST


On Fri, Mar 26, 2021 at 8:11 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Mar 25, 2021 at 11:22:02PM +0200, Alaa Emad wrote:
> > Reported-by: syzbot+a4e309017a5f3a24c7b3@xxxxxxxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Alaa Emad <alaaemadhossney.ae@xxxxxxxxx>
> > ---
>
> I know I do not take patches with no changelog text, but other
> maintainers might be more leniant :(

I wonder if it's the right fix or not.
Initializing variables will, of course, silence the warning, but it's
not necessarily the right fix. I suspect there is something wrong in
how ret/act_len are user/checked.