Re: [PATCH 23/25] HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition

From: Jonathan Cameron
Date: Mon Mar 29 2021 - 11:23:28 EST


On Mon, 29 Mar 2021 14:00:07 +0100
Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> On Mon, 29 Mar 2021, Jonathan Cameron wrote:
>
> > On Fri, 26 Mar 2021 14:34:56 +0000
> > Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/hid/hid-sensor-hub.c:54: warning: Function parameter or member 'hsdev' not described in 'hid_sensor_hub_callbacks_list'
> > >
> >
> > Perhaps nice to mention that this was a result of
> >
> > ca2ed12f163b ("HID: hid-sensor-hub: Processing for duplicate physical ids")
>
> I only tend to do that for Fixes: tags, but Greg has made it clear
> that these patches are not suitable for stable.

Ok, I was deliberately not including Fixes for that reason, but
I guess some other script might moan if we do that :)

>
> > > Cc: Jiri Kosina <jikos@xxxxxxxxxx>
> > > Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> > > Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > > Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> > > Cc: linux-input@xxxxxxxxxxxxxxx
> > > Cc: linux-iio@xxxxxxxxxxxxxxx
> > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> Thanks dude, much appreciated.
>