Re: [PATCH v2 3/3] dt-bindings: serial: 8250: add aspeed,sirq-active-high

[Zev Weiss]

On Wed, Mar 31, 2021 at 11:04:44PM CDT, Andrew Jeffery wrote:
> On Thu, 1 Apr 2021, at 11:27, Zev Weiss wrote:
> > This provides a simpler, more direct alternative to the deprecated
> > aspeed,sirq-polarity-sense property for indicating the polarity of
> > the Aspeed VUART's SIRQ line.
> >
> > Signed-off-by: Zev Weiss <zev@xxxxxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/serial/8250.yaml | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/8250.yaml
> > b/Documentation/devicetree/bindings/serial/8250.yaml
> > index 491b9297432d..e79bb6ab9d2c 100644
> > --- a/Documentation/devicetree/bindings/serial/8250.yaml
> > +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> > @@ -12,8 +12,9 @@ maintainers:
> >  allOf:
> >    - $ref: /schemas/serial.yaml#
> >    - if:
> > -      required:
> > -        - aspeed,sirq-polarity-sense
> > +      anyOf:
> > +        - required: [ aspeed,sirq-active-high ]
>
> Do you think we could make use of the approach I put forward here?
>
> https://lore.kernel.org/openbmc/20210319062752.145730-18-andrew@xxxxxxxx/T/#u
>
> Andrew

If you mean using a u32 property (say aspeed,sirq-polarity) with an 
explicit IRQ_TYPE_LEVEL_{LOW,HIGH} instead of a present/absent bool,
sure, I guess that seems like a somewhat clearer, more orthogonal 
arrangement.


Zev