Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

From: Enrico Weigelt, metux IT consult
Date: Thu Apr 01 2021 - 14:36:03 EST


On 27.03.21 10:46, Henning Schild wrote:

In this case, they seem to be assigned to certain specific functions
(by physical labels on the box), so IMHO the LED names should reflect
that in some ways.

The choice for "status" was because of

/* Miscelleaus functions. Use functions above if you can. */

And those known names do not really come with an explanation of their
meaning. Names like "bluetooth" seem obvious, but "activity" or
"indicator" leave a lot of room for speculation.

Maybe we should revise these and add more functions ?

Can you find out some more details, what these LEDs really had been
intented for ?

--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287