Re: [PATCH] init: add support for zstd compressed modules

From: Nick Terrell
Date: Thu Apr 01 2021 - 15:19:08 EST




> On Apr 1, 2021, at 12:54 AM, torvic9@xxxxxxxxxxx wrote:
>
> Thanks Piotr, good work!
> Question: Is `-T0` really faster in this particular case than the default `-T1`? Are modules installed sequentially?

The zstd CLI produces deterministic output regardless of the number of threads used. `-T1` (or not specifying `-T`) will produce the same output as `-T0`. `-T0` will be faster for large files (at the default level, multiple jobs will be spawned for files > 8MB), and be just as fast as `-T1` for smaller files.

Best,
Nick

> I also saw that Masahiro did some work on modules_install, moving MODULE_COMPRESS from the base Makefile to scripts/Makefile.modinst, so perhaps this should also be moved there at a later point.
>
> Tor Vic