Re: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE

[Christophe Leroy]

Le 29/03/2021 à 03:35, Tan, Ley Foon a écrit :
> > -----Original Message-----
> > From: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> > Sent: Friday, March 26, 2021 9:45 PM
> > To: will@xxxxxxxxxx; danielwa@xxxxxxxxx; robh@xxxxxxxxxx;
> > daniel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> > Cc: linux-arch@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linuxppc-
> > dev@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linuxppc-
> > dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; microblaze
> > <monstr@xxxxxxxxx>; linux-mips@xxxxxxxxxxxxxxx; Tan, Ley Foon
> > <ley.foon.tan@xxxxxxxxx>; openrisc@xxxxxxxxxxxxxxxxxxxx; linux-
> > hexagon@xxxxxxxxxxxxxxx; linux-riscv@xxxxxxxxxxxxxxxxxxx; x86@xxxxxxxxxx;
> > linux-xtensa@xxxxxxxxxxxxxxxx; linux-sh@xxxxxxxxxxxxxxx;
> > sparclinux@xxxxxxxxxxxxxxx
> > Subject: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE
> >
> > This converts the architecture to GENERIC_CMDLINE.
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> > ---
> >   arch/nios2/Kconfig        | 24 +-----------------------
> >   arch/nios2/kernel/setup.c | 13 ++++---------
> >   2 files changed, 5 insertions(+), 32 deletions(-)
> >
> > diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig index
> > c24955c81c92..f66c97b15813 100644
> > --- a/arch/nios2/Kconfig
> > +++ b/arch/nios2/Kconfig
> > @@ -90,31 +90,9 @@ config NIOS2_ALIGNMENT_TRAP
> >
> >   comment "Boot options"
> >
> > -config CMDLINE_BOOL
> > -	bool "Default bootloader kernel arguments"
> > -	default y
> > -
> > -config CMDLINE
> > -	string "Default kernel command string"
> > -	default ""
> > -	depends on CMDLINE_BOOL
> > -	help
> > -	  On some platforms, there is currently no way for the boot loader to
> > -	  pass arguments to the kernel. For these platforms, you can supply
> > -	  some command-line options at build time by entering them here.  In
> > -	  other cases you can specify kernel args so that you don't have
> > -	  to set them up in board prom initialization routines.
> > -
> > -config CMDLINE_FORCE
> > -	bool "Force default kernel command string"
> > -	depends on CMDLINE_BOOL
> > -	help
> > -	  Set this to have arguments from the default kernel command string
> > -	  override those passed by the boot loader.
> > -
> >   config NIOS2_CMDLINE_IGNORE_DTB
> >   	bool "Ignore kernel command string from DTB"
> > -	depends on CMDLINE_BOOL
> > +	depends on CMDLINE != ""
> >   	depends on !CMDLINE_FORCE
> >   	default y
> >   	help
>
> Missing " select GENERIC_CMDLINE" ?

Added in v4

Thanks
Christophe