Re: [PATCH] kunit: make KUNIT_EXPECT_STREQ() quote values, don't print literals

[Shuah Khan]

On 4/2/21 3:35 AM, Brendan Higgins wrote:
> On Fri, Feb 5, 2021 at 2:18 PM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote:
> > Before:
> > >   Expected str == "world", but
> > >       str == hello
> > >       "world" == world
> >
> > After:
> > >   Expected str == "world", but
> > >       str == "hello"
> > <we don't need to tell the user that "world" == "world">
> >
> > Note: like the literal ellision for integers, this doesn't handle the
> > case of
> >    KUNIT_EXPECT_STREQ(test, "hello", "world")
> > since we don't expect it to realistically happen in checked in tests.
> > (If you really wanted a test to fail, KUNIT_FAIL("msg") exists)
> >
> > In that case, you'd get:
> > >   Expected "hello" == "world", but
> > <output for next failure>
> >
> > Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx>
>
> Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>

Hi Daniel,

Please run checkpatch on your patches in the future. I am seeing
a few checkpatch readability type improvements that can be made.

Please make changes and send v2 with Brendan's Reviewed-by.

thanks,
-- Shuah