Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

From: Shakeel Butt
Date: Fri Apr 02 2021 - 21:16:13 EST


On Fri, Apr 2, 2021 at 6:04 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 31 Mar 2021 20:35:02 -0700 Roman Gushchin <guro@xxxxxx> wrote:
>
> > On Thu, Apr 01, 2021 at 11:31:16AM +0800, Miaohe Lin wrote:
> > > On 2021/4/1 11:01, Muchun Song wrote:
> > > > Christian Borntraeger reported a warning about "percpu ref
> > > > (obj_cgroup_release) <= 0 (-1) after switching to atomic".
> > > > Because we forgot to obtain the reference to the objcg and
> > > > wrongly obtain the reference of memcg.
> > > >
> > > > Reported-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> > > > Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
> > >
> > > Thanks for the patch.
> > > Is a Fixes tag needed?
> >
> > No, as the original patch hasn't been merged into the Linus's tree yet.
> > So the fix can be simply squashed.
>
> Help. Which is "the original patch"?

"mm: memcontrol: use obj_cgroup APIs to charge kmem pages"