RE: [EXTERNAL] Re: [PATCH] ASoC: max98390: Add controls for tx path

[Steve Lee]

> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Saturday, April 3, 2021 12:23 AM
> To: Steve Lee <SteveS.Lee@xxxxxxxxxxxxxxxxxxx>
> Cc: lgirdwood@xxxxxxxxx; perex@xxxxxxxx; tiwai@xxxxxxxx;
> ckeepax@xxxxxxxxxxxxxxxxxxxxx; geert@xxxxxxxxxxxxxx;
> rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx; shumingf@xxxxxxxxxxx;
> srinivas.kandagatla@xxxxxxxxxx; krzk@xxxxxxxxxx; dmurphy@xxxxxx;
> jack.yu@xxxxxxxxxxx; nuno.sa@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> alsa-devel@xxxxxxxxxxxxxxxx; ryan.lee.maxim@xxxxxxxxx;
> steves.lee.maxim@xxxxxxxxx
> Subject: [EXTERNAL] Re: [PATCH] ASoC: max98390: Add controls for tx path
> 
> On Fri, Apr 02, 2021 at 12:36:43PM +0900, Steve Lee wrote:
> 
> > +	SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A,
> > +		0, 255, 0),
> 
> I'm not clear what this is (especially given the source selection below) but it
> looks like it should be a mute control?
Yes, each channel of enable and disable control. 
I will update this also configured by TDM slot configuration.  
> 
> > +	SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A,
> > +		0, 255, 0),
> 
> This I'd expect to be tied into machine driver configuration, either DT properties
> or TDM slot configuration - it's not something that looks like it's something
> you'd want to control at runtime.
I will update this with either TDM slot configuration and DT properties.
> 
> > +	SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2,
> > +		0, 255, 0),
> 
> This looks like it should be a DAPM control or possibly a TDM slot configuration -
> look at how the Arizona devices handle routing from multiple TDM slots for the
> DAPM version.
This is for Current Sensing and Voltage sensing slot selection. I will update this as DT properties.