Re: [PATCH 0/3] Refine mtk-cmdq-mailbox callback mechanism

From: Chun-Kuang Hu
Date: Fri Apr 02 2021 - 22:46:08 EST


Hi, Jassi:

Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx> 於 2021年3月15日 週一 上午7:33寫道:
>
> mtk-cmdq-mailbox use proprietary callback mechanism and proprietary
> error number, but these could be replaced by standard callback
> mechanism and standard error number. In addition, use cmdq_pkt as
> callback data to prevent redundnat assignment.
>
> Because client driver still use proprietary mechanism, so keep
> proprietary mechanism until client driver use the standard one.

How do you think about this series?

Regards,
Chun-Kuang.

>
> Chun-Kuang Hu (3):
> mailbox: mtk-cmdq: Remove cmdq_cb_status
> mailbox: mtk-cmdq: Use mailbox rx_callback
> mailbox: mtk-cmdq: Add struct cmdq_pkt in struct cmdq_cb_data
>
> drivers/mailbox/mtk-cmdq-mailbox.c | 24 +++++++++++++++---------
> include/linux/mailbox/mtk-cmdq-mailbox.h | 8 ++------
> 2 files changed, 17 insertions(+), 15 deletions(-)
>
> --
> 2.17.1
>