Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

[Greg KH]

On Sat, Apr 03, 2021 at 06:08:34PM -0400, min.li.xe@xxxxxxxxxxx wrote:
> From: Min Li <min.li.xe@xxxxxxxxxxx>
> 
> This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families
> of timing and synchronization devices.It will be used by Renesas PTP Clock
> Manager for Linux (pcm4l) software to provide support to GNSS assisted
> partial timing support (APTS) and other networking timing functions.
> 
> Current version provides kernel API's to support the following functions
> -set combomode to enable SYNCE clock support
> -read dpll's state to determine if the dpll is locked to the GNSS channel
> -read dpll's ffo (fractional frequency offset) in ppqt
> 
> Signed-off-by: Min Li <min.li.xe@xxxxxxxxxxx>

Any specific reason you are not using the misc_device api?  That would
clean up this driver a lot, there's no need to create a whole class just
for a single driver.

thanks,

greg k-h