Re: [PATCH v2 1/2] iio: trigger: Replace explicit casting and wrong specifier with proper one

[Jonathan Cameron]

On Fri,  2 Apr 2021 20:49:10 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> By unknown reason device name is set with an index casted from int
> to unsigned long while at the same time with "%ld" specifier. Both parts
> seems wrong to me, thus replace replace explicit casting and wrong specifier
> with proper one, i.e. "%d".
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Series applied to the togreg branch of iio.git.

thanks,

Jonathan

> ---
> v2: used %d which is really correct one
>  drivers/iio/industrialio-trigger.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index 32ac1bec25e3..78e30f0f915c 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -75,8 +75,7 @@ int __iio_trigger_register(struct iio_trigger *trig_info,
>  		return trig_info->id;
>  
>  	/* Set the name used for the sysfs directory etc */
> -	dev_set_name(&trig_info->dev, "trigger%ld",
> -		     (unsigned long) trig_info->id);
> +	dev_set_name(&trig_info->dev, "trigger%d", trig_info->id);
>  
>  	ret = device_add(&trig_info->dev);
>  	if (ret)