Re: [PATCH v5 0/2] Introduce the BQ25790 charger driver

[Sebastian Reichel]

Hi,

On Mon, Feb 01, 2021 at 08:17:45PM -0600, Ricardo Rivera-Matos wrote:
> This patchset introduces the BQ25790 integrated buck-boost charging IC.

Please add changelogs compared to previous version to
your cover letters.

> Dan Murphy (2):
>   dt-bindings: power: Add the bq25790 dt bindings
>   power: supply: bq25790: Introduce the BQ25790 charger driver
> 
>  .../bindings/power/supply/bq25790.yaml        |   95 ++
>  drivers/power/supply/Kconfig                  |    8 +
>  drivers/power/supply/Makefile                 |    1 +
>  drivers/power/supply/bq25790_charger.c        | 1100 +++++++++++++++++
>  drivers/power/supply/bq25790_charger.h        |  148 +++
>  5 files changed, 1352 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/bq25790.yaml
>  create mode 100644 drivers/power/supply/bq25790_charger.c
>  create mode 100644 drivers/power/supply/bq25790_charger.h

FYI: I don't have further review notes and wait for a new version
with the things pointed out by Krzysztof being fixed. For cleanup
of usb_register_notifier you might want to check how you fixed the
same issue for bq256xx via bq256xx_charger_reset() or my ignored
comment in v4 patchset.

Thanks,

-- Sebastian

Attachment: signature.asc
Description: PGP signature