Re: [PATCH] power: supply: Use true and false for bool variable

From: Sebastian Reichel
Date: Mon Apr 05 2021 - 06:15:13 EST


Hi,

On Tue, Feb 09, 2021 at 05:58:43PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./include/linux/power_supply.h:507:9-10: WARNING: return of 0/1 in
> function 'power_supply_is_watt_property' with return type bool.
>
> ./include/linux/power_supply.h:479:9-10: WARNING: return of 0/1 in
> function 'power_supply_is_amp_property' with return type bool.
>
> Reported-by: Abaci Robot<abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---

Thanks, queued.

-- Sebastian

> include/linux/power_supply.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index 81a55e9..029e6e9 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -476,12 +476,12 @@ static inline bool power_supply_is_amp_property(enum power_supply_property psp)
> case POWER_SUPPLY_PROP_CURRENT_NOW:
> case POWER_SUPPLY_PROP_CURRENT_AVG:
> case POWER_SUPPLY_PROP_CURRENT_BOOT:
> - return 1;
> + return true;
> default:
> break;
> }
>
> - return 0;
> + return false;
> }
>
> static inline bool power_supply_is_watt_property(enum power_supply_property psp)
> @@ -504,12 +504,12 @@ static inline bool power_supply_is_watt_property(enum power_supply_property psp)
> case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
> case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX:
> case POWER_SUPPLY_PROP_POWER_NOW:
> - return 1;
> + return true;
> default:
> break;
> }
>
> - return 0;
> + return false;
> }
>
> #ifdef CONFIG_POWER_SUPPLY_HWMON
> --
> 1.8.3.1
>

Attachment: signature.asc
Description: PGP signature