Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

From: Jani Nikula
Date: Tue Apr 06 2021 - 05:33:39 EST


On Tue, 06 Apr 2021, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> Given that lowlevel drivers usually cannot implement exactly what a
> consumer requests with pwm_apply_state() there is some rounding involved.
>
> pwm_get_state() traditionally returned the setting that was requested most
> recently by the consumer (opposed to what was actually implemented in
> hardware in reply to the last request). To make this semantic obvious
> rename the function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---

> drivers/gpu/drm/i915/display/intel_panel.c | 4 +--

Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx>


--
Jani Nikula, Intel Open Source Graphics Center