Re: [PATCH v3 2/3] dt-bindings: touchscreen: Add HY46XX bindings

From: Jonathan Neuschäfer
Date: Tue Apr 06 2021 - 09:37:22 EST


In the binding:
> +properties:
> + compatible:
> + enum:
> + - hycon,hycon-hy4613
> + - hycon,hycon-hy4614
> + - hycon,hycon-hy4621
> + - hycon,hycon-hy4623
> + - hycon,hycon-hy4633
> + - hycon,hycon-hy4635

In the example:
> + hycon-hy4633@1c {
> + compatible = "hycon,hy4633";
> + reg = <0x1c>;
> + interrupt-parent = <&gpio2>;
> + interrupts = <5 IRQ_TYPE_EDGE_FALLING>;
> + reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
> + };


Rob's devicetree lint bot detected the mismatch in compatible string
here.

I personally think 'hycon,hy4633' looks better than 'hycon,hycon-hy4633',
because it isn't so redundant.


Best regards,
Jonathan Neuschäfer

Attachment: signature.asc
Description: PGP signature