Re: [PATCH 1/3] fsdax: Factor helpers to simplify dax fault code

From: riteshh
Date: Wed Apr 07 2021 - 06:15:40 EST


On 21/04/07 02:32PM, Shiyang Ruan wrote:
> The dax page fault code is too long and a bit difficult to read. And it
> is hard to understand when we trying to add new features. Some of the
> PTE/PMD codes have similar logic. So, factor them as helper functions to
> simplify the code.
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxx>

Sorry, but above email address is wrong. Either of below is ok.

Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx>
OR
Reviewed-by: Ritesh Harjani <ritesh.list@xxxxxxxxx>

>
>
> ---
> fs/dax.c | 152 ++++++++++++++++++++++++++++++-------------------------
> 1 file changed, 84 insertions(+), 68 deletions(-)