Re: [PATCH v4 1/4] dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense

From: Zev Weiss
Date: Wed Apr 07 2021 - 13:55:35 EST


On Wed, Apr 07, 2021 at 12:25:09PM CDT, Greg Kroah-Hartman wrote:
On Wed, Apr 07, 2021 at 11:56:04AM -0500, Zev Weiss wrote:
On Wed, Apr 07, 2021 at 10:18:31AM CDT, Greg Kroah-Hartman wrote:
> On Fri, Apr 02, 2021 at 01:27:21PM -0500, Zev Weiss wrote:
> > This property ties SIRQ polarity to SCU register bits that don't
> > necessarily have any direct relationship to it; the only use of it
> > was removed in commit c82bf6e133d30e0f9172a20807814fa28aef0f67.
>
> Please write that as:
> c82bf6e133d3 ("ARM: aspeed: g5: Do not set sirq polarity")
>

Ack, will do.

> > Signed-off-by: Zev Weiss <zev@xxxxxxxxxxxxxxxxx>
> > Reviewed-by: Joel Stanley <joel@xxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/serial/8250.yaml | 1 +
> > 1 file changed, 1 insertion(+)
>
> What changed from previous versions? That always goes below the ---
> line.
>

I included an overview of that in the cover letter (https://lore.kernel.org/openbmc/20210402182724.20848-1-zev@xxxxxxxxxxxxxxxxx/);
is it desirable to also have that duplicated in the individual patches in
the series?

Any reason why you didn't include all of the relevant people and mailing
lists in that cover letter? I've never seen it before :)


Ah -- is there a good rule of thumb (or git send-email trick) for that? Set-union of get_maintainer.pl over all the patches in the series?

Zev