Re: [PATCH] liquidio: Fix unintented sign extension of a left shift of a u16

From: patchwork-bot+netdevbpf
Date: Wed Apr 07 2021 - 18:10:21 EST


Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 7 Apr 2021 11:12:48 +0100 you wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The macro CN23XX_PEM_BAR1_INDEX_REG is being used to shift oct->pcie_port
> (a u16) left 24 places. There are two subtle issues here, first the
> shift gets promoted to an signed int and then sign extended to a u64.
> If oct->pcie_port is 0x80 or more then the upper bits get sign extended
> to 1. Secondly shfiting a u16 24 bits will lead to an overflow so it
> needs to be cast to a u64 for all the bits to not overflow.
>
> [...]

Here is the summary with links:
- liquidio: Fix unintented sign extension of a left shift of a u16
https://git.kernel.org/netdev/net-next/c/298b58f00c0f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html