Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

From: Wolfram Sang
Date: Wed Apr 07 2021 - 19:04:26 EST



> Reason for temp variable is for me it's confusing to see statement like
> "rate_khz = rate_khz / 1000".

Yes. And with this clearer calculation, we can maybe skip the HZ_PER_KHZ
define completely and just use plain '1000' as a factor/divider because
it then becomes obvious. I still find the define more confusing than
helpful TBH. But I'll leave the final decision to Yicong Yang.

Attachment: signature.asc
Description: PGP signature