Re: [RESEND 00/25] Rid W=1 warnings from HID

From: Lee Jones
Date: Thu Apr 08 2021 - 03:06:13 EST


On Wed, 07 Apr 2021, Benjamin Tissoires wrote:

> On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> >
> > On Fri, 26 Mar 2021, Lee Jones wrote:
> >
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > Lee Jones (25):
> > > HID: intel-ish-hid: Remove unused variable 'err'
> > > HID: ishtp-hid-client: Move variable to where it's actually used
> > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> > > HID: intel-ish: Supply some missing param descriptions
> > > HID: intel-ish: Fix a naming disparity and a formatting error
> > > HID: usbhid: Repair a formatting issue in a struct description
> > > HID: intel-ish-hid: Fix a little doc-rot
> > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> > > HID: hid-alps: Correct struct misnaming
> > > HID: intel-ish-hid: Fix potential copy/paste error
> > > HID: hid-core: Fix incorrect function name in header
> > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> > > header
> > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> > > HID: hid-picolcd_core: Remove unused variable 'ret'
> > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> > > abuses
> > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> > > HID: hid-uclogic-params: Ensure function names are present and correct
> > > in kernel-doc headers
> > > HID: hid-sensor-custom: Remove unused variable 'ret'
> > > HID: wacom_sys: Demote kernel-doc abuse
> > > HID: hid-sensor-hub: Remove unused struct member 'quirks'
> > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> > > definition
> > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
> >
> > These have been on the list for a couple of weeks now.
> >
> > Is there anything I can do to help expedite their merge?
> >
> > I'm concerned since -rc6 has just been released.
>
> Sorry for the delay.
>
> I am currently queuing them locally and running a few tests on them. I
> don't expect anything to happen, but better be safe than anything.
>
> FWIW, I am splitting the series in 3:
> - 11 patches for intel ish are going to be queued in for-5.13/intel-ish
> - the thrustmaster one in for-5.13/thrustmaster
> - the rest (13 patches) will be sent in for-5.13/warnings.

Sounds good to me. Thanks Benjamin.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog