Re: [PATCH v2] crypto: hisilicon/hpre - delete redundant log

[Herbert Xu]

On Fri, Apr 02, 2021 at 07:24:29PM +0800, Hui Tang wrote:
> 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
> necessary to do it here, so remove it.
> 
> Signed-off-by: Hui Tang <tanghui20@xxxxxxxxxx>
> 
> v1 -> v2:
> - Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero.
> ---
>  drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Your patch description is misleading as the patch does moe than
just remove the redundant printk.  Please rephrase so that it is
clear that the patch is in fact changing behaviour.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt