Re: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code

From: Zev Weiss
Date: Fri Apr 09 2021 - 03:38:45 EST


On Fri, Apr 09, 2021 at 02:24:08AM CDT, Andy Shevchenko wrote:
On Thursday, April 8, 2021, Zev Weiss <zev@xxxxxxxxxxxxxxxxx> wrote:

This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
out of the sysfs store functions in preparation for adding DT
properties that will be poking the same registers. While we're at it,
these functions now provide some basic bounds-checking on their
arguments.



Please, use prefix “serial: 8250_aspeed_vuart:” instead of what you have in
the subject line. I think I have told this already



Ah, sorry -- I fixed the cover letter after your first comment (which had definitely been under-tagged); for the patches themselves I was following the example of the last patch in that particular area (8d310c9107a2), though I guess that wasn't the right model to follow. I'll use the requested format in the future.