Re: [PATCH] crypto: qat: Fix a double free in adf_create_ring

[Herbert Xu]

On Fri, Apr 02, 2021 at 10:13:48AM -0700, Lv Yunlong wrote:
> In adf_create_ring, if the callee adf_init_ring() failed, the callee will
> free the ring->base_addr by dma_free_coherent() and return -EFAULT. Then
> adf_create_ring will goto err and the ring->base_addr will be freed again
> in adf_cleanup_ring().
> 
> My patch sets ring->base_addr to NULL after the first freed to avoid the
> double free.
> 
> Fixes: a672a9dc872ec ("crypto: qat - Intel(R) QAT transport code")
> Signed-off-by: Lv Yunlong <lyl2019@xxxxxxxxxxxxxxxx>
> ---
>  drivers/crypto/qat/qat_common/adf_transport.c | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt