Re: [PATCH v4 00/12] Introduce threaded trace streaming for basic perf record operation

From: Bayduraev, Alexey V
Date: Fri Apr 09 2021 - 06:51:35 EST




On 09.04.2021 0:52, Jiri Olsa wrote:
> On Tue, Apr 06, 2021 at 11:37:26AM +0300, Bayduraev, Alexey V wrote:
>>
>> Changes in v4:
>> - renamed 'comm' structure to 'pipes'
>> - moved thread fd/maps messages to verbose=2
>> - fixed leaks during allocation of thread_data structures
>> - fixed leaks during allocation of thread masks
>> - fixed possible fails when releasing thread masks
>>
>> v3: https://lore.kernel.org/lkml/7d197a2d-56e2-896d-bf96-6de0a4db1fb8@xxxxxxxxxxxxxxx/
>
> hi,
> I recall there was some issue wrt threading and intel_pt,
> which we either need to fixed or we need to disable threads
> for it
>
> [root@krava perf]# ./perf record -e intel_pt// --threads=cpu
> ^C[ perf record: Woken up 121 times to write data ]
> Warning:
> AUX data lost 95 times out of 206!
>
> [ perf record: Captured and wrote 211.364 MB perf.data ]
>
> [root@krava perf]# ./perf script
> Segmentation fault (core dumped)
>
> the fix should already be in the perf/record_threads branch,

Thanks,

As I can see, the fix from perf/record_threads is partially here,
except changes in util/auxtrace.c and setting one_mmap_addr/offset.
I will fix this.

I also try to refactor patches 11 and 12.

Regards,
Alexey

>
> jirka
>