Re: [RFC PATCH 06/10] genirq: Don't mask IRQ within flow handler if IRQ is flow-masked

[Thomas Gleixner]

On Thu, Apr 08 2021 at 16:43, Valentin Schneider wrote:
> +	/*
> +	 * Masking is required if IRQ is ONESHOT and we can't rely on the
> +	 * flow-masking persisting down to irq_finalize_oneshot()
> +	 * (in the IRQ thread).
> +	 */
> +	if ((desc->istate & IRQS_ONESHOT) &&
> +	    (!(chip->flags & IRQCHIP_AUTOMASKS_FLOW) ||
> +	     !(chip->flags & IRQCHIP_EOI_THREADED)))

#define XXXX (IRQCHIP_AUTOMASKS_FLOW | IRQCHIP_EOI_THREADED)

        ((chip->flags & XXXX) != XXXX)

Hmm?

Thanks,

        tglx