Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

From: Jens Axboe
Date: Fri Apr 09 2021 - 10:02:43 EST


On 4/9/21 7:54 AM, angkery wrote:
> From: Junlin Yang <yangjunlin@xxxxxxxxxx>
>
> The return from the call to platform_get_irq() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'irq', so making 'irq' an int, and change the position to
> keep the code format.
>
> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> WARNING: Unsigned expression compared with zero: irq > 0

Applied, thanks.

--
Jens Axboe