Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Change the type and use of a variable

From: Fabio M. De Francesco
Date: Fri Apr 09 2021 - 13:14:06 EST


On Friday, April 9, 2021 4:12:37 PM CEST Greg KH wrote:
> On Thu, Apr 08, 2021 at 01:19:42PM +0200, Fabio M. De Francesco wrote:
> > Change the type of fw_current_in_ps_mode from u8 to bool, because
> > it is used everywhere as a bool and, accordingly, it should be
> > declared as a bool. Shorten the controlling
> > expression of an 'if' statement.
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> > ---
> >
> > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
>
> I now have 3 patches, I think, for this same driver, from you, and I
> have no idea what order they should be applied in.
>
> So I'm going to drop them all. Can you please resend me a patch series,
> with all of the outstanding patches sent to me from you that I have not
> applied yet, so that I know which ones to look at and what order to
> apply them in?
>
I just sent in the series of patches you requested. Hope the work is as you
expected.

Thanks,

Fabio
>
> thanks,
>
> greg k-h