Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

From: Ilias Apalodimas
Date: Fri Apr 09 2021 - 16:34:53 EST


On Fri, Apr 09, 2021 at 12:29:29PM -0700, Jakub Kicinski wrote:
> On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote:
> > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote:
> > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote:
> > > > Co-developed-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
> > > > Co-developed-by: Matteo Croce <mcroce@xxxxxxxxxxxxx>
> > > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>
> > >
> > > Checkpatch says we need sign-offs from all authors.
> > > Especially you since you're posting.
> >
> > Yes it does, we forgot that. Let me take a chance on this one.
> > The patch is changing the default skb return path and while we've done enough
> > testing, I would really prefer this going in on a future -rc1 (assuming we even
> > consider merging it), allowing enough time to have wider tests.
>
> Up to you guys. FWIW if you decide to try for 5.13 the missing signoffs
> can be posted in replies, no need to repost.
Thanks! but...
I think I prefer another repost, including mm-people on the list as well (and
fixing SoB's).
I just noticed noone is cc'ed and patch [2/5] adds a line in mm_types.h

/Ilias