Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

From: Mitali Borkar
Date: Sat Apr 10 2021 - 09:37:22 EST


On Sat, Apr 10, 2021 at 03:14:24PM +0200, Greg KH wrote:
> On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote:
> > Fixed Comparison to NULL can be written as '!...' by replacing it with
> > simpler form i.e. boolean expression. This makes code more readable
> > alternative.
> > Reported by checkpatch.
>
> Checkpatch did not report this specific problem, Julia did :)
>
> And this changelog text does not reflect the commit you made here.
>
Making the changes now.

> >
> > Signed-off-by: Mitali Borkar <mitaliborkar810@xxxxxxxxx>
>
> We need a "Reported-by:" line here to reflect that someone reported the
> problem as well.
>
I am resending this as patch v3. I have to add reprted by Julia, right?

> Ideally it will have a "Fixes:" tag also, but I can add that if you
> don't know how to do that just yet.
>
> thanks,
>
> greg k-h