Re: [PATCH 0/3] staging: iio: cdc: ad7746: remove platform_data in favor of device tree bindings

From: Alexandru Ardelean
Date: Sat Apr 10 2021 - 12:20:46 EST


On Fri, Apr 9, 2021 at 9:50 PM Lucas Stankus <lucas.p.stankus@xxxxxxxxx> wrote:
>
> This patch series aims to replace the platform_struct for the ad7746 driver
> in favor of device tree bindings, creating the dt-bindings documentation in
> the process.
>
> Since the header file was only used to define the struct and the excitation
> level values, it was possible to remove the file entirely.

>From my side: I need to get better at understanding IIO and how to
place some logic of devices into IIO,
I don't know if there is a better approach at converting the current
platform_data into DT/OF.
Maybe Jonathan [or someone else] has some better ideas.
Otherwise the overall approach looks fine from my side.

>
> Lucas Stankus (3):
> dt-bindings: staging: iio: cdc: ad7746: add binding documentation for
> AD7746
> staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output
> staging: iio: cdc: ad7746: use dt binding to set the excitation level
>
> .../bindings/iio/cdc/adi,ad7746.yaml | 79 +++++++++++++++++++
> drivers/staging/iio/cdc/ad7746.c | 43 +++++-----
> drivers/staging/iio/cdc/ad7746.h | 28 -------
> 3 files changed, 100 insertions(+), 50 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/iio/cdc/adi,ad7746.yaml
> delete mode 100644 drivers/staging/iio/cdc/ad7746.h
>
> --
> 2.31.1
>