Re: [PATCH 25/25] staging: rtl8723bs: remove more empty if blocks after DBG_8192C deletion

From: kernel test robot
Date: Sat Apr 10 2021 - 13:30:59 EST

Hi Fabio,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url: https://github.com/0day-ci/linux/commits/Fabio-Aiuto/staging-rtl8723bs-remove-DBG_8192C-tracing-macro/20210410-222529
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 32abcac8037da5dc570c22abf266cbb92eee9fc9
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a140b646e0cc8d3db3e30fc46b3491ecbb2d0b47
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Fabio-Aiuto/staging-rtl8723bs-remove-DBG_8192C-tracing-macro/20210410-222529
git checkout a140b646e0cc8d3db3e30fc46b3491ecbb2d0b47
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function 'CardDisableRTL8723BSdio':
>> drivers/staging/rtl8723bs/hal/sdio_halinit.c:881:5: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
881 | u8 ret = _FAIL;
| ^~~
drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function '_ReadAdapterInfo8723BS':
drivers/staging/rtl8723bs/hal/sdio_halinit.c:1156:16: warning: variable 'start' set but not used [-Wunused-but-set-variable]
1156 | unsigned long start;
| ^~~~~


vim +/ret +881 drivers/staging/rtl8723bs/hal/sdio_halinit.c

554c0a3abf216c Hans de Goede 2017-03-29 870
554c0a3abf216c Hans de Goede 2017-03-29 871 /* */
554c0a3abf216c Hans de Goede 2017-03-29 872 /* Description: */
554c0a3abf216c Hans de Goede 2017-03-29 873 /* RTL8723e card disable power sequence v003 which suggested by Scott. */
554c0a3abf216c Hans de Goede 2017-03-29 874 /* */
554c0a3abf216c Hans de Goede 2017-03-29 875 /* First created by tynli. 2011.01.28. */
554c0a3abf216c Hans de Goede 2017-03-29 876 /* */
554c0a3abf216c Hans de Goede 2017-03-29 877 static void CardDisableRTL8723BSdio(struct adapter *padapter)
554c0a3abf216c Hans de Goede 2017-03-29 878 {
554c0a3abf216c Hans de Goede 2017-03-29 879 u8 u1bTmp;
554c0a3abf216c Hans de Goede 2017-03-29 880 u8 bMacPwrCtrlOn;
554c0a3abf216c Hans de Goede 2017-03-29 @881 u8 ret = _FAIL;
554c0a3abf216c Hans de Goede 2017-03-29 882
554c0a3abf216c Hans de Goede 2017-03-29 883 /* Run LPS WL RFOFF flow */
554c0a3abf216c Hans de Goede 2017-03-29 884 ret = HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_enter_lps_flow);
554c0a3abf216c Hans de Goede 2017-03-29 885
554c0a3abf216c Hans de Goede 2017-03-29 886 /* ==== Reset digital sequence ====== */
554c0a3abf216c Hans de Goede 2017-03-29 887
554c0a3abf216c Hans de Goede 2017-03-29 888 u1bTmp = rtw_read8(padapter, REG_MCUFWDL);
554c0a3abf216c Hans de Goede 2017-03-29 889 if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */
554c0a3abf216c Hans de Goede 2017-03-29 890 rtl8723b_FirmwareSelfReset(padapter);
554c0a3abf216c Hans de Goede 2017-03-29 891
554c0a3abf216c Hans de Goede 2017-03-29 892 /* Reset MCU 0x2[10]= 0. Suggested by Filen. 2011.01.26. by tynli. */
554c0a3abf216c Hans de Goede 2017-03-29 893 u1bTmp = rtw_read8(padapter, REG_SYS_FUNC_EN + 1);
554c0a3abf216c Hans de Goede 2017-03-29 894 u1bTmp &= ~BIT(2); /* 0x2[10], FEN_CPUEN */
554c0a3abf216c Hans de Goede 2017-03-29 895 rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp);
554c0a3abf216c Hans de Goede 2017-03-29 896
554c0a3abf216c Hans de Goede 2017-03-29 897 /* MCUFWDL 0x80[1:0]= 0 */
554c0a3abf216c Hans de Goede 2017-03-29 898 /* reset MCU ready status */
554c0a3abf216c Hans de Goede 2017-03-29 899 rtw_write8(padapter, REG_MCUFWDL, 0);
554c0a3abf216c Hans de Goede 2017-03-29 900
554c0a3abf216c Hans de Goede 2017-03-29 901 /* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */
554c0a3abf216c Hans de Goede 2017-03-29 902 u1bTmp = rtw_read8(padapter, REG_RSV_CTRL + 1);
554c0a3abf216c Hans de Goede 2017-03-29 903 u1bTmp &= ~BIT(0);
554c0a3abf216c Hans de Goede 2017-03-29 904 rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp);
554c0a3abf216c Hans de Goede 2017-03-29 905 u1bTmp = rtw_read8(padapter, REG_RSV_CTRL + 1);
554c0a3abf216c Hans de Goede 2017-03-29 906 u1bTmp |= BIT(0);
554c0a3abf216c Hans de Goede 2017-03-29 907 rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp);
554c0a3abf216c Hans de Goede 2017-03-29 908
554c0a3abf216c Hans de Goede 2017-03-29 909 /* ==== Reset digital sequence end ====== */
554c0a3abf216c Hans de Goede 2017-03-29 910
554c0a3abf216c Hans de Goede 2017-03-29 911 bMacPwrCtrlOn = false; /* Disable CMD53 R/W */
554c0a3abf216c Hans de Goede 2017-03-29 912 ret = false;
554c0a3abf216c Hans de Goede 2017-03-29 913 rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
554c0a3abf216c Hans de Goede 2017-03-29 914 ret = HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_card_disable_flow);
554c0a3abf216c Hans de Goede 2017-03-29 915 }
554c0a3abf216c Hans de Goede 2017-03-29 916

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip