Re: [PATCH 4/7] mm: Introduce verify_page_range()

From: Christoph Hellwig
Date: Mon Apr 12 2021 - 04:28:10 EST


On Mon, Apr 12, 2021 at 10:00:16AM +0200, Peter Zijlstra wrote:
> +extern int verify_page_range(struct mm_struct *mm,

No need for the extern here.

> +int verify_page_range(struct mm_struct *mm,
> + unsigned long addr, unsigned long size,
> + int (*fn)(pte_t pte, unsigned long addr, void *data),
> + void *data)

A kerneldoc comment would be nice for this function.

Otherwise this looks fine.