Re: [PATCH v2 2/3] dt-bindings: mfd: pm8008: Add bindings

[Rob Herring]

On Fri, Apr 09, 2021 at 05:55:01PM -0700, Guru Das Srinagesh wrote:
> Add bindings for the Qualcomm Technologies, Inc. PM8008 MFD driver.
> 
> Signed-off-by: Guru Das Srinagesh <gurus@xxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/mfd/qcom,pm8008.yaml       | 119 +++++++++++++++++++++
>  1 file changed, 119 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> new file mode 100644
> index 0000000..0cafa98
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/qcom,pm8008.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. PM8008 PMIC bindings
> +
> +maintainers:
> +  - Guru Das Srinagesh <gurus@xxxxxxxxxxxxxx>
> +
> +description: |
> +  Qualcomm Technologies, Inc. PM8008 is a dedicated camera PMIC that integrates
> +  all the necessary power management, housekeeping, and interface support
> +  functions into a single IC.
> +
> +properties:
> +  compatible:
> +    const: qcom,pm8008
> +
> +  reg:
> +    description:
> +      I2C slave address.
> +
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +    description: Parent interrupt.
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +    description: |
> +      The first cell is the IRQ number, the second cell is the IRQ trigger
> +      flag. All interrupts are listed in include/dt-bindings/mfd/qcom-pm8008.h.
> +
> +  interrupt-controller: true
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  "^pinctrl@[0-9a-f]+$":

Doesn't look like a pin controller. 'gpio@...' instead.

> +    type: object

       additionalProperties: false

> +
> +    description: |
> +      The GPIO peripheral. This node may be specified twice, one for each GPIO.
> +
> +    properties:
> +      compatible:
> +        const: qcom,pm8008-gpio
> +
> +      reg:
> +        description: Peripheral address of one of the two GPIO peripherals.
> +        maxItems: 1
> +
> +      gpio-controller: true
> +
> +      interrupt-controller: true
> +
> +      "#interrupt-cells":
> +        const: 2
> +
> +      "#gpio-cells":
> +        const: 2
> +
> +    required:
> +      - compatible
> +      - reg
> +      - gpio-controller
> +      - interrupt-controller
> +      - "#gpio-cells"
> +      - "#interrupt-cells"
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#address-cells"
> +  - "#size-cells"
> +  - "#interrupt-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/mfd/qcom-pm8008.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    qupv3_se13_i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      pm8008i@8 {
> +        compatible = "qcom,pm8008";
> +        reg = <0x8>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        interrupt-controller;
> +        #interrupt-cells = <2>;
> +
> +        interrupt-parent = <&tlmm>;
> +        interrupts = <32 IRQ_TYPE_EDGE_RISING>;
> +
> +        pinctrl@c000 {
> +          compatible = "qcom,pm8008-gpio";
> +          reg = <0xc000>;
> +          gpio-controller;
> +          #gpio-cells = <2>;
> +          interrupt-controller;
> +          #interrupt-cells = <2>;
> +        };
> +      };
> +    };
> +
> +...
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>