Re: [PATCH v8 4/8] mm,memory_hotplug: Allocate memmap from the added memory range

From: Oscar Salvador
Date: Fri Apr 16 2021 - 06:38:03 EST


On Fri, Apr 16, 2021 at 12:33:34PM +0200, David Hildenbrand wrote:
> IIRC, we have to add the zero shadow first, before touching the memory. This
> is also what mm/memremap.c does.
>
> In mhp_deinit_memmap_on_memory(), you already remove in the proper
> (reversed) order :)

But looking at online_pages(), we do it after the
move_pfn_range_to_zone(), right? AFAIK (I might be well wrong here),
memory_notify() will eventually call kasan_add_zero_shadow? So that
comes after the move_pfn_range_to_zone? Or is my understanding
incorrect?


--
Oscar Salvador
SUSE L3