Re: [PATCH] PCI: shpchp: remove unused function

From: Bjorn Helgaas
Date: Fri Apr 16 2021 - 12:23:55 EST


On Thu, Apr 15, 2021 at 04:30:22PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/pci/hotplug/shpchp_hpc.c:177:20: warning: unused function
> 'shpc_writeb' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>

Applied to pci/hotplug for v5.13 with the following subject, thanks!

PCI: shpchp: Remove unused shpc_writeb()

> ---
> drivers/pci/hotplug/shpchp_hpc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
> index db04728..9e3b277 100644
> --- a/drivers/pci/hotplug/shpchp_hpc.c
> +++ b/drivers/pci/hotplug/shpchp_hpc.c
> @@ -174,11 +174,6 @@ static inline u8 shpc_readb(struct controller *ctrl, int reg)
> return readb(ctrl->creg + reg);
> }
>
> -static inline void shpc_writeb(struct controller *ctrl, int reg, u8 val)
> -{
> - writeb(val, ctrl->creg + reg);
> -}
> -
> static inline u16 shpc_readw(struct controller *ctrl, int reg)
> {
> return readw(ctrl->creg + reg);
> --
> 1.8.3.1
>