Re: [PATCH V4 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP

From: Mathieu Poirier
Date: Fri Apr 16 2021 - 13:58:58 EST


On Thu, Apr 15, 2021 at 09:27:33PM +0800, peng.fan@xxxxxxxxxxx wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> V4:
> Typo fix
> patch 4: take state as a check condition
> patch 5: move regmap lookup/attach to imx_rproc_detect_mode
> patch 6: add imx_rproc_clk_enable for optional clk
> patch 8: use switch/case in imx_rproc_detect_mode
> V3:
> Add A-b tag for Patch 1/2
> Fix the checkpatch warning for Patch 6,8
>
> V2:
> Patch 1/8, use fsl as vendor, typo fix
> Because patchset [1] has v2 version, patch 5,6,7,8 are adapted that
> change.
>
> This patchset is to support i.MX7ULP/8MN/8MP, also includes a patch to
> parse fsl,auto-boot
>

Always specify what branch your work applies on and dependencies for it. If
this was ready to go Bjorn would have a fun time figuring out it depends on your
other set[1].

I am done reviewing this pathset.

Mathieu

[1] [PATCH V3 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP

>
> Peng Fan (8):
> dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot property
> dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support
> dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P
> remoteproc: imx_rproc: parse fsl,auto-boot
> remoteproc: imx_rproc: initial support for mutilple start/stop method
> remoteproc: imx_rproc: make clk optional
> remoteproc: imx_rproc: support i.MX7ULP
> remoteproc: imx_rproc: support i.MX8MN/P
>
> .../bindings/remoteproc/fsl,imx-rproc.yaml | 11 +-
> drivers/remoteproc/imx_rproc.c | 206 +++++++++++++++++----
> 2 files changed, 179 insertions(+), 38 deletions(-)
>
> --
> 2.7.4
>