Re: [PATCH v3] drm/bridge/sii8620: fix dependency on extcon
From: Randy Dunlap
Date: Mon Apr 19 2021 - 13:11:24 EST
On 4/19/21 2:01 AM, Robert Foss wrote:
> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
> on EXTCON, which causes issues when sii8620 is built
> as a builtin and EXTCON is built as a module.
> The symptoms are 'undefined reference' errors caused
> by the symbols in EXTCON not being available
> to the sii8620 driver.
> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> LKP reported issue:
> Changes since v1:
> - Fix typo on comment
> Changes since v2:
> - Randy: Changed from `depends` to `select`
I don't know why my name is on that. I didn't
suggest any change -- I just reported that v2
had a problem.
> drivers/gpu/drm/bridge/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 22a467abd3e9..70402da5cc70 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620
> tristate "Silicon Image SII8620 HDMI/MHL bridge"
> depends on OF
> select DRM_KMS_HELPER
> - imply EXTCON
> + select EXTCON
> depends on RC_CORE || !RC_CORE
> Silicon Image SII8620 HDMI/MHL bridge chip driver.
Thanks. Works For Me.
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested