Re: [PATCH] brcmsmac: fix shift on 4 bit masked value
From: Kalle Valo
Date: Wed Apr 21 2021 - 05:08:09 EST
Joe Perches <joe@xxxxxxxxxxx> writes:
> On Sun, 2021-04-18 at 06:10 +0000, Kalle Valo wrote:
>> Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>> > The calculation of offtune_val seems incorrect, the u16 value in
>> > pi->tx_rx_cal_radio_saveregs is being masked with 0xf0 and then
>> > shifted 8 places right so that always ends up as a zero result. I
>> > believe the intended shift was 4 bits to the right. Fix this.
>> > [Note: not tested, I don't have the H/W]
>> > Addresses-Coverity: ("Operands don't affect result")
>> > Fixes: 5b435de0d786 ("net: wireless: add brcm80211 drivers")
>> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>> I think this needs review from someone familiar with the hardware.
>> Patch set to Changes Requested.
> What "change" are you requesting here?
Don't take patchwork states literally, a better name for this state
would be "Needs work" or something like that.
> Likely there needs to be some other setting for the patch.
> Perhaps "deferred" as you seem to be requesting a review
> and there's no actual change necessary, just approval from
> someone with the hardware and that someone test the patch.
I already asked for help on April 7th and nobody replied, so I'm
dropping this now. The patch can be resent if/when the change is
confirmed to be correct.