Re: [PATCH] static_call: Fix unused variable warning

From: Guenter Roeck
Date: Wed Apr 21 2021 - 21:45:43 EST


On 4/21/21 6:33 PM, Steven Rostedt wrote:
> On Wed, 21 Apr 2021 18:24:15 -0700
> Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
>> On 4/21/21 5:41 PM, Steven Rostedt wrote:
>>>
>>> Second patch with the exact same update. Perhaps we should take one
>>> before we get more of them ;-)
>>>
>>> https://lore.kernel.org/lkml/20210416194300.3952208-1-cmllamas@xxxxxxxxxx/
>>>
>>
>> Sorry, I missed the other one.
>>
>
>
> That's OK, I just thought you might have been doing some "research" on us.
>

Not amused. I don't play such games.

No, this causes a compile error for us for a build with CONFIG_MODULES=n
in combination with -Werror. The problem was backported to v5.10.y with
the merge of v5.10.28, which makes it worse because it introduced a
regression into that branch. A regression causing a compile error isn't
really improving confidence in the test coverage of stable releases.

Unfortunately there was a miscommunication internally; my understanding
was that no patch was submitted upstream.

Guenter