Re: [PATCH] usb: musb: davinci: change the variable type

From: Greg KH
Date: Thu Apr 22 2021 - 04:49:17 EST


On Mon, Apr 19, 2021 at 12:06:18AM +0530, Saurav Girepunje wrote:
> vbus_state is define as bool but on davinci.c assigning a value
> '-1' to the bool variable.

Does it also test that value?

If so, shouldn't that logic error be fixed instead of working around it
by changing the variable type?

This feels wrong...

thanks,

greg k-h