Re: [PATCH 4/4] MIPS: Avoid DIVU in `__div64_32' is result would be zero

From: Maciej W. Rozycki
Date: Thu Apr 22 2021 - 05:12:54 EST


On Thu, 22 Apr 2021, Thomas Bogendoerfer wrote:

> > Thomas, as this mistake has spread across three out of these patches,
> > both in change descriptions and actual code, would you mind dropping the
> > series from mips-next altogether and I'll respin the series with all
> > these issues corrected?
>
> I'm sorry, but I don't rebase mips-next and the patches have been pushed
> out before I received this mail.

Hmm, what about changes known to actually break something then? Like
with R6 here? Those will undoubtedly cause someone a headache with
bisection sometime in the future. Are you sure your policy is the best
possible?

NB, I have benchmarked the update with my DECstation, however my Malta
has not come up after a reboot last evening and neither it has after a few
remote power cycles. I have planned a visit in my lab next week anyway,
so I'll see what has happened there; hopefully I'm able to bring the board
back to life as I find it valuable for my purposes. I had to replace the
PSU it came with already a couple years back and the new one is supposedly
high-quality, so I fear it's the board itself.

Meanwhile I'll be able to give DECstation figures only. I guess such
limited results will suffice if I post the fix as an update rather than
replacement.

Maciej